Merged
Conversation
Rather than the API attempt to retrieve a missing attribute for every item during 'get' use a local default instead. Removal led to test failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Slow Run Retrieval
Issue: #846
Python Version(s) Tested: 3.13
Operating System(s): Ubuntu 25.04
📝 Summary
The retrieval of
Runobjects is very slow for large quantities.🔍 Diagnosis
get_runshasalerts=Falsebutalertsis a property of theRunLLAPI class. The base class__repr__method iterates through all properties meaning because the"alerts"key was missing the automatic 'get from server' method was being called for each run.🔄 Changes
I have removed this automatic retrieval, hopefully it does not break things.Addedlocal_defaultvalue to be used when object is in "local" mode."Local" mode used forget- bulk item retrieval.Run(...).alertswhen they usedget_runs(alerts=False)aKeyErrorwill be returned.✔️ Checklist